node-muneem / anumargak

Simple but Fastest Web Router in nodejs

Other

39 stars 5 forks source link

Updated 'on()' to allow multiple urls per handle #11

Closed ghost closed 6 years ago

ghost commented 6 years ago

Resolves #10

Changes:

Update on() to allow passing an array of urls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 68

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 95.833%

Totals
Change from base Build 67:	0.04%
Covered Lines:	410
Relevant Lines:	420

💛 - Coveralls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 69

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-95.8%) to 0.0%

Totals
Change from base Build 67:	-95.8%
Covered Lines:	0
Relevant Lines:	0

💛 - Coveralls

amitguptagwl commented 6 years ago

@veraschngr have you done with your changes?

ghost commented 6 years ago

@amitguptagwl I've actually updated the tests. You can see them in https://github.com/node-muneem/anumargak/pull/11/commits/6c66a8d8873afd31b1f96cbcbb47bf218449d77a.

amitguptagwl commented 6 years ago

Thanks @veraschngr for your changes

amitguptagwl commented 6 years ago

Thanks @veraschngr for your changes

amitguptagwl commented 6 years ago

Thanks. There is some issue with Github so I'm not able to merge this PR. But will do as soon as the issue is resolved.

On Sun, 21 Oct 2018 at 22:34, Vera Schöniger notifications@github.com wrote:

@amitguptagwl https://github.com/amitguptagwl I've actually updated the tests. You can see them in 6c66a8d https://github.com/node-muneem/anumargak/commit/6c66a8d8873afd31b1f96cbcbb47bf218449d77a .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/node-muneem/anumargak/pull/11#issuecomment-431685648, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVgKB2dSiNFrv6pQFvW238FOS7jHjC1ks5unKkLgaJpZM4XLZJI .

-- Cheers Amit Gupta