search

node-muneem / anumargak

Simple but Fastest Web Router in nodejs
Other
39 stars 5 forks source link

#12 added registeredRoutes() to return all static and dynamic routes #13

Closed jdiehl closed 6 years ago

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 73

Totals Coverage Status
Change from base Build 70: 0.06%
Covered Lines: 415
Relevant Lines: 425
💛 - Coveralls
amitguptagwl commented 6 years ago

Have you tested it against versioned URLs? I was wondering if we should return a formatted list in form of URL tree so the result can be understood by the users. A handler may decide to log the formatted list of all registered routes, but printing handler may reveal secure code as well.

jdiehl commented 6 years ago

The method returns all dynamic and static routes as an unordered list with all properties of the routes included. Hopefully this will provide a good start to start building additional features, such as the suggested url tree or special handling of versions.

amitguptagwl commented 6 years ago

.. this will provide a good start to start building additional features ..

I'm sorry but a PR is expected not to be just an enabler for other features. We're strict on the policy of "Design for future, Code for current".