node-muneem / anumargak

Simple but Fastest Web Router in nodejs
Other
39 stars 5 forks source link

Supports simply use of regular expression #7

Closed shuklajay117 closed 6 years ago

shuklajay117 commented 6 years ago

Changes:

@amitguptagwl Please review

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 47


Totals Coverage Status
Change from base Build 40: 0.06%
Covered Lines: 621
Relevant Lines: 623

💛 - Coveralls
shuklajay117 commented 6 years ago

I'm struggling with squash commits which I've done yesterday and earlier. Can you guide me on this?

Hopefully, I'm able to squash all commits which I've made just now and also able to remove your updates from this PR.

amitguptagwl commented 6 years ago

I checked your commits. So ideally you should not see any issue. However you can pull my changes and rebase your changes

git pull --rebase origin master

Add remote pointing to this repo and use this name instead of origin in above command.

shuklajay117 commented 6 years ago

I did as you suggested and still I see older commits. Also, I see 2 commits in my local branch where I see one of that is yours.

shuklajay117 commented 6 years ago

Finally able to manage. Thanks for your help.

amitguptagwl commented 6 years ago

Awesome