search

node-oauth / express-oauth-server

🔒 Complete, compliant and well tested module for implementing an OAuth2 Server/Provider with express in node.js
https://www.npmjs.com/package/@node-oauth/express-oauth-server
MIT License
29 stars 8 forks source link

Include types for the package #10

Closed shrihari-prakash closed 1 year ago

shrihari-prakash commented 1 year ago

For the express-oauth-server counterpart from oauthjs, there are types specified in DefinitelyTyped: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/express-oauth-server/index.d.ts

However for this project, there is nothing of that sort. It would be good to include the typings file from DefinitelyTypes and point to it in package.json. Right now, when I import the package on TypeScript projects, it would complain that there is no types associated:

image

shrihari-prakash commented 1 year ago

Hello @jankapunkt , @HappyZombies , I added types for this package from DefinitelyTyped. Could you please review and merge this if you feel it's okay? https://github.com/node-oauth/express-oauth-server/pull/11

jankapunkt commented 1 year ago

published in 3.0.1