search

node-oauth / express-oauth-server

🔒 Complete, compliant and well tested module for implementing an OAuth2 Server/Provider with express in node.js
https://www.npmjs.com/package/@node-oauth/express-oauth-server
MIT License
29 stars 8 forks source link

update project to ES6 standards #12

Closed HappyZombies closed 1 year ago

HappyZombies commented 1 year ago

Closes #4

TBH, lot of questionable stuff but I made changed a few simple things where it made sense. But as a whole I have a lot of questions on what this package is actually...doing. Would like to create a future item or discussion on how we can make this middleware even better.

But for the time being, yes see the code changes. Uses ES6 stuff; pointing arrow functions, class, await/async and more.

Let me know what y'all think 😃

Oh yeah and all unit tests pass and bluebird is removed (though technically it's still present since node-oauth/node-oauth2-server is a dependency of this...(which has bluebird))

jankapunkt commented 1 year ago

Should we publish as new major or just as a minor? Might be breaking for some using deprecated node engines.

HappyZombies commented 1 year ago

@jankapunkt i think minor tbh but I could understand an argument for major.

This was previously set to version "0.11" which I think is one from 2013? I think tbh...time to upgrade buddy lol besides the "engine" property in NPM is a suggestion and will throw a warning to the user

https://docs.npmjs.com/cli/v9/configuring-npm/package-json#engines