search

node-oauth / express-oauth-server

🔒 Complete, compliant and well tested module for implementing an OAuth2 Server/Provider with express in node.js
https://www.npmjs.com/package/@node-oauth/express-oauth-server
MIT License
27 stars 8 forks source link

Is this going to replace oauthjs/express-oauth-server ? #5

Closed relu91 closed 1 year ago

relu91 commented 2 years ago

Just passing by and I was wondering if this fork will be published under https://www.npmjs.com/package/express-oauth-server soon or after. With https://github.com/eclipse/thingweb.node-wot we are having annoying npm audit problems that I would like to resolve. Thank you for your time! :)

cancan101 commented 2 years ago

following up here and wondering if the package will be published under the @node-oauth org on npm?

casret commented 2 years ago

Yep would also like for this to published.

jankapunkt commented 1 year ago

Hey @relu91 @cancan101 @casret I did not watch the repo to I totally missed these comments. There are some other comments as well in the main repo asking for this.

I would go an extra round and look for updating this repo. However, I do not actively use the oauth2 server with express so I need a bit of your requirements on what actually needs to be updated.

jankapunkt commented 1 year ago

@relu91 @cancan101 @casret please review this PR: #7 The more reviewers we have the faster we can publish

relu91 commented 1 year ago

Thank you for pinging me back. As I said in the beginning our main use case is to have a test server that is fully compliant with oAuth2 protocol to verify that our client is behaving correctly. I'll check #7

jankapunkt commented 1 year ago

I got it reviewed from one maintainer of our org who uses express plus from an external so I published the updated version with no audit issues (updated dependencies) and the new OAuth2 server from this org.

It's available from npm via: https://www.npmjs.com/package/@node-oauth/express-oauth-server

relu91 commented 1 year ago

I'll try ASAP and I'll let you know.

cancan101 commented 1 year ago

How do I get typescript to see the types for this new package? When I had previously installing this package from GitHub, I had been using this package @types/express-oauth-server to add types. Now that I am installing from npm using @node-oauth/express-oauth-server, typescript is no longer seeing the types.

jankapunkt commented 1 year ago

The types were related to the original repo. Since we didn't change the API it should work if we create a types.ts file and copy the one from the types repo, right?

jankapunkt commented 1 year ago

@cancan101 @relu91 the types would be added in this PR: #11 please review and confirm/deny so we can merge and move forward with this :-)

relu91 commented 1 year ago

Everything was fine, thank you really much!