node-oauth / node-oauth2-server

🚀 The successor to oauthjs/oauth2-server. 🔒 Complete, compliant, maintained and well tested OAuth2 Server for node.js. Includes native async await and PKCE.
https://www.npmjs.com/package/@node-oauth/oauth2-server
MIT License
307 stars 45 forks source link

Improve documentation by adding jsDoc compatible method documentations #160

Open jankapunkt opened 2 years ago

jankapunkt commented 2 years ago

I found many functions lack of proper parameter descriptions, for example in server.js. Especially options are often completely undocumented.

jankapunkt commented 2 years ago

Also the README should add a "migrate from 3.x" guide, even if there are no breaking issues

jankapunkt commented 1 year ago

@HappyZombies @jorenvandeweyer I have fiddled around with RST but it's a real struggle :see_no_evil:

My proposal would be:

What do you think?

jorenvandeweyer commented 1 year ago

I agree. I'd suggest using Vitepress! Simple to setup and markdown templates.

jorenvandeweyer commented 1 year ago

If you want I can set it up.

jankapunkt commented 1 year ago

@jorenvandeweyer sounds promising! We can try to work on this on a separate branch. Does it support jsDoc?

jorenvandeweyer commented 1 year ago

@jankapunkt No it does not support jsDoc, do we need it?

jankapunkt commented 1 year ago

I think we are good with the current docs for now but in the long run jsDoc is a good way for API docs as the functions are documented in place