node-oauth / node-oauth2-server

🚀 The successor to oauthjs/oauth2-server. 🔒 Complete, compliant, maintained and well tested OAuth2 Server for node.js. Includes native async await and PKCE.

https://www.npmjs.com/package/@node-oauth/oauth2-server

MIT License

288 stars 39 forks source link

Fixes ignoring scope on refresh token call #238

Closed jorenvandeweyer closed 11 months ago

jorenvandeweyer commented 1 year ago

Summary

Fixes #104
Rewrote scopes to only allow an array of strings instead of where before both a string and an array of strings were allowed.
Validate scopes safely BREAKING: validateScope must now only return an array of strings or a falsy value.
Updated docs (also removed places still mentioning callbacks)

Linked issue(s)

104 #194

Involved parts of the project

Scopes

Added tests?

Yes & updated existing tests

OAuth2 standard

See #104

jorenvandeweyer commented 1 year ago

@jankapunkt I targeted the PR to the release-5.0.0 branch to avoid merge conflicts since this branch is ahead of development

I think we should asap merge release-5.0.0 into development. We can do this before or after merging this PR.

shrihari-prakash commented 1 year ago

@jankapunkt , @jorenvandeweyer , will there be one more RC to test this change? I think this is already breaking with my project and maybe I can do a code change and test this to see if things are smooth before 5.0.0?

jorenvandeweyer commented 1 year ago

@jankapunkt can there be a RC of this PR?

jankapunkt commented 1 year ago

Hi @jorenvandeweyer @shrihari-prakash I was sick the last days jost got back today :dizzy: I will merge later today and create an rc

jankapunkt commented 11 months ago

@jorenvandeweyer would you mind shortly reviewing my comments? I think it's ready to merge I just want to make sure there is nothing missing etc. I can create a new release ASAP once it's merged

jorenvandeweyer commented 11 months ago

@jankapunkt sorry for the delay, I updated the PR.

It should be ready to be merged now!