node-oauth / node-oauth2-server

🚀 The successor to oauthjs/oauth2-server. 🔒 Complete, compliant, maintained and well tested OAuth2 Server for node.js. Includes native async await and PKCE.
https://www.npmjs.com/package/@node-oauth/oauth2-server
MIT License
321 stars 46 forks source link

RFC-Conformity depends on Implementation #79

Open Uzlopak opened 3 years ago

Uzlopak commented 3 years ago

We should document, that some conformity rules can only be implemented by the express/fastify/koa-etc. layer.

Maybe we should collect the MUST rules for meeting the conformity requirements but are (currently?) out of scope of the oauth2-server.

https://datatracker.ietf.org/doc/html/rfc6749#section-3.1
- TLS is also necessary, which is not enforced by the oauth2-server

The authorization server MUST require the use of TLS as described in Section 1.6 when sending requests using password authentication.

https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1

- Brute-Force Protection for the endpoints is also a MUST regarding the RFC. 

Since this client authentication method involves a password, the authorization server MUST protect any endpoint utilizing it against brute force attacks.

jankapunkt commented 3 years ago

This is a very good idea, because it would help client implementations to write their own compliance suite much more efficiently.

jankapunkt commented 3 years ago

We should create a documentation like COMPLIANCE.md for that.