feat: add description and displayName

Renaud-R-Koerber commented 9 months ago

add description and displayName to base object when crawling. Those values are already present in the CacheNode object

CLAassistant commented 9 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

erossignon commented 9 months ago

Thank you for your contribution. We require that you sign the CLA (Contributor Licence agreement) before we can accept your PR.

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7181059376

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.008%) to 92.57%

Files with Coverage Reduction	New Missed Lines	%
packages/node-opcua-client/source/client_session_keepalive_manager.ts	3	82.67%
<!--	Total:	3		-->

Totals
Change from base Build 7103733609:	-0.008%
Covered Lines:	35059
Relevant Lines:	37873

💛 - Coveralls

erossignon commented 8 months ago

closed in favor of #1338

node-opcua / node-opcua