node-real / bsc-erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
125 stars 40 forks source link

Lack of reward trace in v1.2.6 #386

Closed MRabenda closed 4 months ago

MRabenda commented 4 months ago

A few months ago we saved all traces obtained from BSC-Erigon node using trace_block and such a response had a reward trace. We are trying to do the same right now - and the reward trace is missing is this correct behavior? I am attaching here 2 files for block 27999834. As you can see in the old one we can find

{
   "action":{
      "author":"0x8b6c8fd93d6f4cea42bbb345dbc6f0dfdb5bec73",
      "rewardType":"block",
      "value":2000000000000000000
   },
   "blockHash":"0x8613c7426bd8f01c6b308a8271c5cb4a39fda515e0599253d89d81a428dc1126",
   "blockNumber":27999834,
   "result":null,
   "subtraces":0,
   "traceAddress":[

   ],
   "type":"reward"
}

Where in the new one it is not available 27999834_new.json 27999834_old.json

We checked this for many blocks and always difference between them is 1 trace (reward trace)

MatusKysel commented 4 months ago

Hey @MRabenda old version v1.1.* used to return just static value for rewards, ConstantinopleBlockReward = uint256.NewInt(2e+18). In new version there is nothing returned as information wasn't really useful nor correct

MRabenda commented 4 months ago

@MatusKysel Would you be able to share more in the context of what you mean by it was not correct? There was not a block reward at all? Let's say in block 27999834 an address 0x8b6c8fd93d6f4cea42bbb345dbc6f0dfdb5bec73 did not receive a block reward of value 2000000000000000000 ?

MatusKysel commented 4 months ago

yeah, for each block there was a constant reward for author of the block and it was wrong

MRabenda commented 4 months ago

Thank you for information