search

node-real / bsc-erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
121 stars 41 forks source link

Refactor: ApplyFlagsForEthConfig to handle different pruning modes based on chainId #507

Closed du5 closed 2 months ago

blxdyx commented 2 months ago

There have PruneDistanceFlag and PruneBlocksDistanceFlag, so i think we don't need this. https://github.com/node-real/bsc-erigon/blob/c45c84ce5ed3d4fc5346dc55ca09654cab5a6b04/turbo/cli/flags.go#L94-L101

du5 commented 2 months ago

There have PruneDistanceFlag and PruneBlocksDistanceFlag, so i think we don't need this.

https://github.com/node-real/bsc-erigon/blob/c45c84ce5ed3d4fc5346dc55ca09654cab5a6b04/turbo/cli/flags.go#L94

I think this can reduce the length of the startup parameters. This modification can make --prune.mode=minimal --chain=bsc equivalent to --prune.mode=archive --prune.distance.blocks=90000 --prune.distance=90000 --chain=bsc