node-real / bsc-erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
124 stars 42 forks source link

Erigon alpha3 not returning logs when topics are null #529

Open MetFiWheel opened 2 days ago

MetFiWheel commented 2 days ago

System information

Erigon version: erigon version 1.3.0-alpha3

OS & Version: Linux erigon 5.10.0-19-amd64 #1 SMP Debian 5.10.149-2 (2022-10-21) x86_64 GNU/Linux

Commit hash:

Erigon Command (with flags/config):

/opt/bsc-erigon1.3.0-alpha3/build/bin/erigon --chain=bsc --datadir=/srv/erigonData --metrics --metrics.addr=0.0.0.0 --metrics.port=6060 --private.api.addr=0.0.0.0:9090 --pprof --pprof.addr=0.0.0.0 --pprof.port=6061 --http --ws --http.api=eth,erigon,web3,net,debug,trace,txpool --http.vhosts="*" --metrics --metrics.addr 0.0.0.0 --log.dir.path /var/log/erigon/ --log.dir.json --sync.loop.block.limit=10_000 --batchSize=2g --db.pagesize=16k --bodies.cache=214748364800

Chain/Network: BSC

Expected behaviour

Logs returned

Actual behaviour

No logs returned, empty array

{ "jsonrpc": "2.0", "method": "eth_getLogs", "id": 1, "params": [ { "address": [ "0xb11ca7e6fb1cc882479da3367ec3ab22ddc90277" ], "fromBlock": "0x28bd04d", "toBlock": "0x28bdc4d", "topics": [ [ "0xc89f73aba5662742d9f8b7b898beebe28877d269b59d3ae5ffe5b081c2bc70a4" ], null, null, null ] } ] }

Steps to reproduce the behaviour

Use abigen to generate contract bindings and call FilterSomeLog with nil as the parameter for the indexed event field.

STdevK commented 2 days ago

What's the error message returned?

MetFiWheel commented 1 day ago

No error message, the result is HTTP 200 OK with an empty JSON array.

MetFiWheel commented 1 day ago

HTTP payload is generated by abigen contract binding, worked without issues with erigon 1.2.

MatusKysel commented 1 day ago

Hey @MetFiWheel, yes current version has it disabled, you can expect to have it in next one.