search

node-red-contrib-ibm-cloud / community

A central repository for co-ordinating the node-red-contrib-ibm-cloud community
Apache License 2.0
3 stars 1 forks source link

Proposal: Cloudant nodes #1

Open knolleary opened 4 years ago

knolleary commented 4 years ago

The original cloudant node is node-red-node-cf-cloudant by @lgfa29. This is the node included in the Node-RED Starter App on IBM Cloud.

There have been a number of forks of the node, most notably node-red-contrib-cloudantplus maintained by @hammoaj

The cloudantplus node is actively maintained and has added a number of features over the original node. It has been (rightly) published with a different set of node types so it doesn't cause clashes if a user installs both nodes.

I have permission from @lgfa29 to take ownership of the npm module of the original node so we can publish updates to it.

I also have the support of @hammoaj who will be joining this community.

The tentative plan is:

  1. fork node-red-node-cf-cloudant into this organisation
  2. merge the changes from cloudantplus into that repository
  3. update the node types back to the original ones
  4. publish a new version of the original node to npm.
  5. update (with help from @lgfa29) the original cf-cloudant repository readme to mark it as deprecated and point to the repo in this organisation
  6. update (with help from @hammoaj) the original cloudantplus repository to mark it as deprecated and point to the repo in this organisation

We may want to have a small period where updates are made to both the cf-cloudant repo and the original cloudantplus repo. This will allow updates to be made to both npm modules (with their different node types), to give users time to migrate back to cf-cloudant module.

That gets us to a clean baseline for the future development of the node.

Stwissel commented 3 years ago

Move this: https://github.com/insectos/node-red-contrib-cloudantplus too?

hammoaj commented 3 years ago

I don't think so, my version had all of the latest fixes so one we've agreed that you're btw code is the definitive node then we should get all others deprecated.

On Sat, 19 Jun 2021 at 22:01, Stephan H. Wissel @.***> wrote:

Move this: https://github.com/insectos/node-red-contrib-cloudantplus too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/node-red-contrib-ibm-cloud/community/issues/1#issuecomment-864463193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFBISNTRK3CYSKZYCAD3IR3TTUATZANCNFSM4MIPGWJA .

--

Adam Hammond @.***

Stwissel commented 3 years ago

;-) We all agree we need to do an "Highlander" to all the forks out there. As long as it is current, I'm good with any name/location for the Nodes

johnwalicki commented 3 years ago

One path forward would be to rebase node-red-node-cf-cloudant on node-red-contrib-cloudantplus and adopt it as the forward code base. With that migration, upstream would move here, get a millions? of downstream apps to upgrade. Gives us a supported (@hammoaj and others) solution.

johnwalicki commented 3 years ago

There's discussion here too https://github.com/IBM/node-red-app/pull/77

knolleary commented 3 years ago

@johnwalicki that's exactly what the plan has always been. We have done the rebase and merged here: https://github.com/node-red-contrib-ibm-cloud/node-red-node-cf-cloudant/pull/1

The missing step is getting that published to npm.

If we can dbl check the code in that repo looks good, we can get it it published.

hammoaj commented 3 years ago

Nick,

Stephan has done an excellent job of updating the node so we probably need to do another re-base once it’s tested and then publish.

We then need to look at pulling some of Stephan’s code into the Cloudant file storage code.

On Wed, 23 Jun 2021 at 06:45, knolleary @.***> wrote:

@johnwalicki https://github.com/johnwalicki that's exactly what the plan has always been. We have done the rebase and merged here: node-red-contrib-ibm-cloud/node-red-node-cf-cloudant#1 https://github.com/node-red-contrib-ibm-cloud/node-red-node-cf-cloudant/pull/1

The missing step is getting that published to npm.

If we can dbl check the code in that repo looks good, we can get it it published.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/node-red-contrib-ibm-cloud/community/issues/1#issuecomment-866546607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFBISNRWWCGZDOADMLPJEMDTUFYIPANCNFSM4MIPGWJA .

--

Adam Hammond @.***

knolleary commented 3 years ago

Happy to take your guidance on what the next steps are. I don't have access to cloudant these days to test the node myself.

If you think the updates from Stephen are needed, then lets get them PR'd into the repo.

hammoaj commented 2 years ago

The latest cloudantplus code has now been published to npm. So I think that we are now ready to rebase the original node on the cloudantplus code. What is the best way of deprecating a node on Node-RED? I was thinking that once the original node is rebased and published, I would update the README to suggest people switch to the core node, but wasn't sure of whether there was a way of "redirecting" one node to use another more permanently.