search

node-red-contrib-ibm-cloud / community

A central repository for co-ordinating the node-red-contrib-ibm-cloud community
Apache License 2.0
3 stars 1 forks source link

Proposal: DB2 Nodes #4

Open knolleary opened 3 years ago

knolleary commented 3 years ago

The existing node-red-nodes-cf-sqldb-dashdb set of nodes can be used for db2, but the dash part of the name is deprecated branding. It is maintained by @smchamberlin, who has proposed to republish the module but updated to db2 branding.

We're going to take this opportunity to add the newly branded module to this org.

Here's the current proposal:

  1. clone node-red-nodes-cf-sqldb-dashdb to this org
  2. rename it to node-red-contrib-ibm-db2
  3. rename the individual node types to something db2 related - need to avoid clashing with any of the existing db2 related nodes
  4. publish to npm
  5. update the existing node-red-nodes-cf-sqldb-dashdb module to include a deprecation notice and point to the new modules name and guidance on swapping over node types.
  6. Update the starter kit to pull in the new node instead of the old one.
smchamberlin commented 3 years ago

Hi @knolleary ,

Proposal sounds good to me.

  1. For clone node-red-nodes-cf-sqldb-dashdb to this org - I don't believe I have the appropriate access to do this, can you please confirm?

  2. I have already renamed my node-red-nodes-cf-sqldb-dashdb git to node-red-contrib-ibm-db2, it can be found here: https://github.com/smchamberlin/node-red-contrib-ibm-db2

  3. I have done this as well - new node types are "Db2". I confirmed that this is not used yet.

Other Db2-related node-RED npm’s :

Node-red-contrib-db2 https://github.com/mfou/node-red-contrib-db2 registerTypes: IbmDBdatabase, ibmdb

Node-red-contrib-db2-fixed ihttps://github.com/TimonLukas/node-red-contrib-db2-fixed registerTypes: IbmDBdatabase, ibmdb

Node-red-contrib-db2-for-i https://github.com/IBM/node-red-contrib-db2-for-i registerTypes: DB2 for i, DB2 for i Config

Node-red-contrib-deebeetwoforzed https://github.ibm.com/soheel-chughtai/node-red-contrib-zeddeebeetwo registerTypes: zdb2, zdb2config

  1. Tried to do this today but got a spam detection error - I have cc'd you on my email to NPM support. npm ERR! publish Failed PUT 403 npm ERR! code E403 npm ERR! Package name triggered spam detection; if you believe this is in error, please contact support@npmjs.com : node-red-contrib-ibm-db2

  2. I added the deprecation notice to node-red-nodes-cf-sqldb-dashdb today: https://www.npmjs.com/package/node-red-nodes-cf-sqldb-dashdb

  3. I think you need to pull the lever on this one when ready.

Thanks!

smchamberlin commented 3 years ago

In the meanwhile while we figure out the spam issue I have undeprecated node-red-nodes-cf-sqldb-dashdb.

chughts commented 3 years ago

The home repo for the DB2 for Z nodes is https://github.com/ibm-early-programs/node-red-contrib-deebeetwoforzed

knolleary commented 3 years ago

@smchamberlin we maybe should have put the deprecation notice on the dashdb nodes after we had the new module published... but no matter.

I'm happy for you to go ahead with the clone and rename into this org.

Once cloned, I'd suggest updating the readme of the original repo to include a link to its new home here.

@chughts how feasible is it to roll in the Z support into this module? Or does it need to remain a separate module?

chughts commented 3 years ago

@knolleary It should be, but the difficulty is acquiring DB2 on Z for test. I wrote it because I couldn't get the dashdb nodes to work with Z. If the DB2 nodes work against Z then my nodes become redundant.

smchamberlin commented 3 years ago

Hi @knolleary ,

Repo has been forked into this org:

https://github.com/node-red-contrib-ibm-cloud/node-red-contrib-ibm-db2

and I have added a link to the original repo to here:

https://github.com/smchamberlin/node-red-contrib-ibm-db2/blob/master/README.md

I have tested the new npm on my local with npm install and it seems to work fine. But I don’t see it show up yet in the Node-RED palette when I search for “db2” - does that take some time ?

New NPM: https://www.npmjs.com/package/node-red-contrib-ibm-db2

Old NPM is deprecated: https://www.npmjs.com/package/node-red-nodes-cf-sqldb-dashdb

Are we ready to update the starter kit? Thanks.

knolleary commented 3 years ago

@smchamberlin you'll need to submit it to the flow library yourself https://flows.nodered.org/add/node

Will submit a pr to the starter kit tomorrow.

smchamberlin commented 3 years ago

Great, one question, currently I'm the only one who can write or administer the NPM module. I think I can add others as well. Should I add anyone else?

knolleary commented 3 years ago

@smchamberlin please add me and @dceejay as a minimum - that should ensure someone is available to publish an update if the need arises.

knolleary commented 3 years ago

PR raised on the starter kit - https://github.com/IBM/node-red-app/pull/26

smchamberlin commented 3 years ago

@smchamberlin please add me and @dceejay as a minimum - that should ensure someone is available to publish an update if the need arises.

@knolleary Will do - but can I please have your NPM id's ? Thanks

knolleary commented 3 years ago

@smchamberlin knolleary and dceejay

Tip: you can run npm owner ls <name-of-module> to see the owners of a module and get their usernames.

smchamberlin commented 3 years ago

Thank you, knolleary and dceejay have been added as maintainers with write access.