More unit tests, fixes for some failing unit tests

node-red-quantum / node-red-contrib-quantum

Quantum computing functionality for Node-RED

https://node-red-quantum.github.io/

Apache License 2.0

16 stars 2 forks source link

More unit tests, fixes for some failing unit tests #105

Closed ttoktassynov closed 3 years ago

ttoktassynov commented 3 years ago

Purpose

To check that nodes correctly validate incoming inputs. Minor fixes for some test cases.

Changes

Added tests that check that node fail on receiving input from non-quantum nodes and on receiving non-qubit or non-register objects (ec25e3f)
Fixed Pass qubit through gate tests that were failing because assertion wasn't done on aggregate list of qubit payloads, but rather on the first one (909ad4f). The only node that still has this failing test is Multi-controlled U gate
Fixed Execute command test for Quantum Register node failing because of uninitialized outputs variable (b14823f)
Fixed flaky test in bloch sphere spec file (f017bf1)
Added a test to script node to check for correct output, fixed commandExecute test util function to check for input once, since several inputs result in test error (11cf675)

New Requirements

louislefevre commented 3 years ago

Just pushed commit 6da350a48036c8d463931444b45bbcfe510ad2e0 to remove a redundancy: nodeId is always the same as flowBuilder.inputId, so there is no need to have it as a parameter. Furthermore, since these ids are always the same, we only need to call getNode() once.

Anyway, approved 👍

ttoktassynov commented 3 years ago

Just pushed commit 6da350a to remove a redundancy: nodeId is always the same as flowBuilder.inputId, so there is no need to have it as a parameter. Furthermore, since these ids are always the same, we only need to call getNode() once.

Anyway, approved 👍

The idea was to have a nodeFailed function to which I could send any node Id in the flow , which I know might fail. I thought it’s not always the first in the flow. But I agree currently it is redundant.