search

node-red / linux-installers

Node-RED install scripts for various flavours of Linux
Apache License 2.0
94 stars 63 forks source link

Install script for Raspberry Pi overwrites custom nodered.service #25

Closed ralphwetzel closed 2 years ago

ralphwetzel commented 2 years ago

Hi there! I used to have node-red 2.1.4 running on a RPi. Installation was done according to the given instruction. I've customized /lib/systemd/system/nodered.service to define some special parameters - e.g. --userDir.

Today I just upgraded this installation - again following the instruction given - to node-red 2.1.5.

After successfull completion of the process I discovered, that my customized /lib/systemd/system/nodered.service was overwritten.

Proposal: Only create nodered.service, if it's missing - but do not overwrite it. Edge case: If there's a breaking change in nodered.service, that's mandatory to be installed - backup the current file & raise a supportive comment during installation.

dceejay commented 2 years ago

sensible suggestion.

ralphwetzel commented 2 years ago

:+1: I'll propose a PR.