Edit option of a 'Link' added in the Dashboard 'Tab & Links' section doesn't work in v3.1.0 - it works in v3.0.1

juggledad commented 9 months ago

Current Behavior

If you open the 'Dashboard' tab in the right sidebar of the Node-red editor and select the 'Layout' tab and click the '+link' button a 'Link gets created but you can not edit it. This worked in NR v3.0.2 dashboard v3.4.0 and dashboard updated to v3.6.0 but does not work in NR v3.1.0.

The dashboard version does not matter I tested on NR v3.0.2 with dashboard v3.4.0 and it worked. I upgraded the dashboard to v3.6.0 and am not able to edit the link. It also does not work on NR v3.1.0.

Expected Behavior

Clicking the 'edit` button should let you edit the configuration

Steps To Reproduce

run NR v3.1.0 and open the right sidebar. Select the Dashboard tab -> Tabs & Links and click the + link button.
go to teh Link it creates and click on the edit button to see the issue.

Example flow

paste your flow here

Environment

Node-RED version: 3.1.0 node v18.12.1 and 3.0.2 node v16.20.2
Node.js version:
npm version:
Platform/OS: macOS and RPI
Browser: Safari, FireFox nad Chrome

Steve-Mcl commented 9 months ago

@dceejay I suspect this needs transferring to dashboard repo - would you agree?

dceejay commented 9 months ago

Not until we double check it's not a 3.1 issue

dceejay commented 9 months ago

weird, can't see why it broke, but fix pushed to master, 3.6.1

jeremielabelle commented 8 months ago

I have the same Issue, please if possible let us know in this thread when the new npm will be available to fix this issue, thank you !

juggledad commented 8 months ago

@jeremielabelle update the dashboard node to v3.6.1 and it is fixed. After updating you may need to stop/restart NR and clear your browser cache.

jeremielabelle commented 8 months ago

Just saw that, thank you very much it worked like a charm. Have a great day.

node-red / node-red-dashboard