fix NODE_OPTIONS - Githubissues

node-red / node-red-docker

Repository for all things Node-RED and Docker related

Apache License 2.0

481 stars 383 forks source link

fix NODE_OPTIONS #333

Closed twocolors closed 2 years ago

twocolors commented 2 years ago

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Checklist

[ ] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[ ] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

linux-foundation-easycla[bot] commented 2 years ago

:x: - login: @twocolors / name: D . The commit (d29684c966db6bfea11d0394cfe3159da32e79b8) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

hardillb commented 2 years ago

Thanks for this, but as mentioned in the contribution guide we can't accept it without a signed CLA. Otherwise I can make the change and close the PR.

I know this is a relatively trivial change, but it also helps to include even a tiny description in the PR.

twocolors commented 2 years ago

hmm, ok i logged in. What should happen, resend PR?

hardillb commented 2 years ago

/easycla

hardillb commented 2 years ago

Assuming the commit is signed by a public email address attached to your github account then it should verify.

https://docs.linuxfoundation.org/v2/easycla/getting-started/easycla-troubleshooting#github-unable-to-contribute-to-easycla-enforced-repositories

twocolors commented 2 years ago

Oh, i have verify email and make commit from web .

Steve-Mcl commented 2 years ago

Oh, i have verify email and make commit from web .

Hi @twocolors, did you actually click the link to sign the CLA?...

Please click here to be authorized.

twocolors commented 2 years ago

@Steve-Mcl yep , my profile https://openprofile.dev/profile/twocolors

Steve-Mcl commented 2 years ago

@Steve-Mcl yep , my profile https://openprofile.dev/profile/twocolors

I don't believe that is the same thing.

Can you try again please...

Please click here to be authorized.

twocolors commented 2 years ago

@Steve-Mcl yep , my profile https://openprofile.dev/profile/twocolors

I don't believe that is the same thing.

Can you try again please...

Please click here to be authorized.

yes i try, is okey

Steve-Mcl commented 2 years ago

/easycla

Steve-Mcl commented 2 years ago

/easycla

hardillb commented 2 years ago

Since we are having problems getting this signed off via easyCLA I'll apply it from a PR from my account with a note that @twocolors provided the fix. ( #334 )