search

node-red / node-red-docker

Repository for all things Node-RED and Docker related
Apache License 2.0
481 stars 383 forks source link

Interest in a Debian-version of node-red-docker? #340

Closed VincentSC closed 1 year ago

VincentSC commented 1 year ago

I ported node-red-docker to Docker, and it solved #305

Is there interest in the port? If yes, I'll share my code.

dceejay commented 1 year ago

The main node-red-docker project has instructions here - https://github.com/node-red/node-red-docker/tree/master/docker-custom

tomaszduda23 commented 1 year ago

Would it be possible to publish official debian version on docker hub? Alpine has a problem with DNS so it would be nice to has debian version also.

hardillb commented 1 year ago

Publishing to docker hub comes with doubling the support overhead, so there would need to be a truly compelling reasons to do so.

Do you have a link to the DNS problem you mentioned?

tomaszduda23 commented 1 year ago

In some cases DNS in alpine just work randomly. When you need to call e.g. some rest API from node-red it is pretty annoying. The easiest way to solve it is debian base image.

https://github.com/alpinelinux/docker-alpine/issues/165 https://gitlab.alpinelinux.org/alpine/tsc/-/issues/43 https://news.ycombinator.com/item?id=28312935 https://news.ycombinator.com/item?id=30642632

VincentSC commented 1 year ago

Choosing Debian is not simply for the sake of preference, but for NodeRed to be actually functioning properly.

This is not a preference-discussion like Vim-vs-Emacs. I would therefore stress that it's utterly important to start serving Debian-based dockers on Docker Hub. I actually don't care which more mature Linux is used - as long as it does not have the issues like Alpine has.

As I have written my own docker-build for Debian, I'm totally in the state of WFM ¯_(ツ)_/¯. But... I would like to see NR to get accepted for low-coding a lot more, and this issue is obstructing that.

hardillb commented 1 year ago

There a test debian build (along with all the other 3.1.0-beta.2 builds here

https://hub.docker.com/r/nodered/node-red-dev/tags

VincentSC commented 1 year ago

Thanks a lot! I need to find a good moment to test this outside office hours - I'll get back to you with test-results.

The test I roughly have in mind:

VincentSC commented 1 year ago

Tested this setup for a few months:

FROM nodered/node-red-dev:v3.1.0-beta.2-debian

USER root

RUN apt update
RUN apt install -y nano iputils-ping
RUN usermod -aG dialout node-red

USER node-red

It has been working flawlessly!

ingvarso commented 1 year ago

Because of the DNS-resolver issues in Alpine base image, and therefore allmost daily crashes in Node Red, I swiched to building a custom Debian image a month ago. After that, I have not experienced further crashes. In my opinion this is a good reason for also providing a Debian based image at the docker hub.

hardillb commented 1 year ago

@ingvarso A debian based build was included in the Node-RED 3.1.0 release yesterday. It is available with the following tags:

https://hub.docker.com/r/nodered/node-red/tags

It is based on NodeJS 16

hardillb commented 1 year ago

Closing as the 3.1 debian build has shipped