node-red / node-red-docker

Repository for all things Node-RED and Docker related
Apache License 2.0
469 stars 382 forks source link

Image with Debian and 18 #392

Closed AndreKR closed 9 months ago

AndreKR commented 9 months ago

Node.js 16 is getting pretty old and there are nodes on npm that don't support 16 anymore.

Would it be possible to bump the Node.js version of the Debian images to 18?

hardillb commented 9 months ago

NodeJS version bumps will happen in Node-RED 4.0

AndreKR commented 9 months ago

Depending on when that will happen, would it in the meantime be possible to provide "-18" images like there already are for Alpine?

hardillb commented 9 months ago

No, we will not be increasing the number of containers we already have to maintain and support.

If you need a container based on NodeJS 18 you can build your own using the scripts in the docker-custom directory

luixal commented 6 months ago

Just tried this, but both options (alpine and debian) fail in something related to the konwn_hosts.sh script:

#########################################################################
node-red version: 3.1.3
#########################################################################
[+] Building 132.4s (10/18)                                                                                                                                                                                                                                                                                                              docker:default
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                                                                  0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                                                                                    0.0s
 => [internal] load build definition from Dockerfile.custom                                                                                                                                                                                                                                                                                        0.1s
 => => transferring dockerfile: 3.59kB                                                                                                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/amd64/node:18-alpine                                                                                                                                                                                                                                                                                    1.4s
 => [base  1/10] FROM docker.io/amd64/node:18-alpine@sha256:8842b060b01af71c082cee310b428a2d825e940d9fd9e450e05d726aea66a480                                                                                                                                                                                                                       6.5s
 => => resolve docker.io/amd64/node:18-alpine@sha256:8842b060b01af71c082cee310b428a2d825e940d9fd9e450e05d726aea66a480                                                                                                                                                                                                                              0.0s
 => => sha256:8842b060b01af71c082cee310b428a2d825e940d9fd9e450e05d726aea66a480 1.16kB / 1.16kB                                                                                                                                                                                                                                                     0.0s
 => => sha256:f3776b60850deec9eb1da7746fa20b3f000bf153408dc896d6606704c83f948d 7.14kB / 7.14kB                                                                                                                                                                                                                                                     0.0s
 => => sha256:661ff4d9561e3fd050929ee5097067c34bafc523ee60f5294a37fd08056a73ca 3.41MB / 3.41MB                                                                                                                                                                                                                                                     0.3s
 => => sha256:0f158788f409a5decd9495205daf4aa17df26d8219d6dc12acab5949342866fe 40.24MB / 40.24MB                                                                                                                                                                                                                                                   1.8s
 => => sha256:f028dff98271801e449c3ebac94a319851128c0ec687e13e00a68b2d98ec4700 2.34MB / 2.34MB                                                                                                                                                                                                                                                     0.6s
 => => extracting sha256:661ff4d9561e3fd050929ee5097067c34bafc523ee60f5294a37fd08056a73ca                                                                                                                                                                                                                                                          0.4s
 => => sha256:18f25c33705ddc3351cc4893fdc0a38405bdd0741643798918fa2b0146fd5a9d 451B / 451B                                                                                                                                                                                                                                                         0.6s
 => => extracting sha256:0f158788f409a5decd9495205daf4aa17df26d8219d6dc12acab5949342866fe                                                                                                                                                                                                                                                          3.8s
 => => extracting sha256:f028dff98271801e449c3ebac94a319851128c0ec687e13e00a68b2d98ec4700                                                                                                                                                                                                                                                          0.3s
 => => extracting sha256:18f25c33705ddc3351cc4893fdc0a38405bdd0741643798918fa2b0146fd5a9d                                                                                                                                                                                                                                                          0.0s
 => [internal] load build context                                                                                                                                                                                                                                                                                                                  0.0s
 => => transferring context: 262B                                                                                                                                                                                                                                                                                                                  0.0s
 => [base  2/10] COPY scripts/*.sh /tmp/                                                                                                                                                                                                                                                                                                           0.2s
 => [base  3/10] RUN set -ex &&     apk add --no-cache         bash         tzdata         iputils         curl         nano         git         openssl         openssh-client         ca-certificates &&     mkdir -p /usr/src/node-red /data &&     deluser --remove-home node &&     adduser -h /usr/src/node-red -D -H node-red -u 1000 &&    3.1s
 => [base  4/10] WORKDIR /usr/src/node-red                                                                                                                                                                                                                                                                                                         0.1s
 => [base  5/10] COPY known_hosts.sh .                                                                                                                                                                                                                                                                                                             0.1s
 => ERROR [base  6/10] RUN ./known_hosts.sh /etc/ssh/ssh_known_hosts && rm /usr/src/node-red/known_hosts.sh                                                                                                                                                                                                                                      120.8s
------
 > [base  6/10] RUN ./known_hosts.sh /etc/ssh/ssh_known_hosts && rm /usr/src/node-red/known_hosts.sh:
120.7 ssh-keyscan failed, no more retries left
------
Dockerfile.custom:36
--------------------
  34 |     # Setup SSH known_hosts file
  35 |     COPY known_hosts.sh .
  36 | >>> RUN ./known_hosts.sh /etc/ssh/ssh_known_hosts && rm /usr/src/node-red/known_hosts.sh
  37 |     RUN echo "PubkeyAcceptedKeyTypes +ssh-rsa" >> /etc/ssh/ssh_config
  38 |
--------------------
ERROR: failed to solve: process "/bin/sh -c ./known_hosts.sh /etc/ssh/ssh_known_hosts && rm /usr/src/node-red/known_hosts.sh" did not complete successfully: exit code: 1
hardillb commented 6 months ago

@luixal Please do not use closed issue to report unrelated problems.

This failure implies that one of the git services we pre-populate the container with has changed their SSH keys (again). Please open a new issue and I'll look at it a little later.

hardillb commented 6 months ago

@luixal Also I've just run this with the head of the master branch and everything is working as expecting, so when you open the new issue please include a lot more detail about exactly what you did

S474N commented 2 months ago

In connection with latest-debian and especially the node.js 16 version, I have problem with the installation of NRCHKB :(

https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/552

hardillb commented 2 months ago

New versions will ship with Node-RED v4.0, you can use the beta containers if needed