Upgrade Node Version - Githubissues

node-red / node-red-docker

Repository for all things Node-RED and Docker related

Apache License 2.0

469 stars 382 forks source link

Upgrade Node Version #402

Closed khanetor closed 2 months ago

khanetor commented 6 months ago

Include Node 20 for Alpine build Set default Node version to 18 for both Alpine and Debian builds

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[ ] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

linux-foundation-easycla[bot] commented 6 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: khanetor / name: Kha (299c96296d8a5cad3c001092737a522aaddbab82, 2ff402ba57b9007de688aa499fe33de382c84a2c)

knolleary commented 6 months ago

We will not be changing the default image version until Node-RED 4.0 as it is a breaking change otherwise.

hardillb commented 6 months ago

Thanks for this, but we can not change the default latest target without a major version number bump and we will not be adding extra version containers to the currently supported list.

When Node-RED 4.0 ships (which is intended to be relatively soon) we will update the versions.

khanetor commented 6 months ago

We will not be changing the default image version until Node-RED 4.0 as it is a breaking change otherwise.

I can revert that back, but are you okay with including Node 20?

beasteers commented 5 months ago

Adding a version 18 (and 20?) for the debian images would be useful as well

khanetor commented 2 months ago

Adding a version 18 (and 20?) for the debian images would be useful as well

Well, these guys are not interested in having newer LTS node versions.

knolleary commented 2 months ago

@khanetor we've explained our plans for updating node versions. Node-RED 4.0, due in the next month, will ship with 18/20.

We are already publishing the beta images - nodered/node-red-dev:v4.0.0-beta.2 which defaults to Node 20.

khanetor commented 2 months ago

@khanetor we've explained our plans for updating node versions. Node-RED 4.0, due in the next month, will ship with 18/20.

We are already publishing the beta images - nodered/node-red-dev:v4.0.0-beta.2 which defaults to Node 20.

I'm aware. But it is still not here.

hardillb commented 2 months ago

Apologies I should have closed this sooner, there will be no nodejs.v20 builds on the 3.x release.

Please test the beta builds Nick pointed to as that it's the best way to help get the release out as soon as possible.

hardillb commented 2 months ago

Just to add one more thing, we can not just add 20 to the build matrix for the 3.1.x builds.

If you look at the 4.0.0 beta builds you will see we have had to drop the ARMv7 32bit builds because npm just hangs when run under docker buildx build and qemu (very similar to the s390x builds) when run from a GitHub Action and nobody has been able to work out why.

I get the same result on my 2 different (Intel) laptops , but others don't on similar hardware.