search

node-red / node-red-node-swagger

A set of tools for generating Swagger api documentation based on the HTTP nodes deployed in a flow
Apache License 2.0
63 stars 48 forks source link

Enable multiple node types with swagger doc. Depends on optional NR_S… #47

Closed oprince closed 7 years ago

oprince commented 7 years ago

Enable multiple node types with swagger doc. Depends on optional NR_Settings configuration: swagger.endPoints - array with supported node types.

Example: swagger: { "endPoints": ["http in", "stream in"], ....

jsf-clabot commented 7 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: oprince
:x: Orit Prince

Orit Prince seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

oprince commented 7 years ago

CLA is signed, and email address for that commit is my primary address: oritp@il.ibm.com

knolleary commented 7 years ago

@oprince you need to add the email address used for this commit to your account before the CLA tool will accept it.

oprince commented 7 years ago

This change was suggested by my colleague Amnon, discussed and agreed with Nick on node-red slack:

image

oprince commented 7 years ago

@knolleary it was there before. Can it be merged now ?

knolleary commented 7 years ago

@oprince the commit is signed by the email address oritp@ili.ibm.com - note ili not il.

oprince commented 7 years ago

@knolleary Please check the last commit. I have reset git settings user.email on my local machine before commit.

knolleary commented 7 years ago

Hi @oprince, this PR now has a mix of commits from different email addresses. Can I suggest you close this PR and open a new one containing one commit with the proper email address and then everything should work.