node-red / node-red-node-test-helper

A test framework for Node-RED nodes
Apache License 2.0
57 stars 40 forks source link

Feature/add continuous integration/circleci #39

Closed doublethefish closed 2 years ago

doublethefish commented 4 years ago

This adds CircleCI auto-test and running of the examples to node-red-node-test-helper.

Example of it running against my repo: https://circleci.com/gh/doublethefish/node-red-node-test-helper

In addition to the great benefits of using CI, part of the intent here is to demonstrate how to run the tests and examples, bolstering the pretty good documentation.

jsf-clabot commented 4 years ago

CLA assistant check
All committers have signed the CLA.

doublethefish commented 3 years ago

Can I get an update on this? Or should I just close it?

knolleary commented 3 years ago

Hi, sorry to have overlooked this for so long.

We use Travis in the main project repository. Not keen to introduce another 3rd party service as a dependency for us to have to maintain.

doublethefish commented 3 years ago

Grand, thanks for the update. I shall close and log an issue to get a badge added to the main repo.

doublethefish commented 3 years ago

Ah, I misunderstood your reply. I was going through my history, according to #7 you have travis in the main repo, which is not this one.

So would you be amiable to having a travis setup on this repo?

I want to see that the system is green, and know how to test it, before contributing.

knolleary commented 3 years ago

Yup, a Travis setup would be welcome.

doublethefish commented 3 years ago

Just a quick update whilst I try to find time to look at this again. When I ran travis against this repo a few days back it failed.

I cloned the main repo's travis config, but I've not yet done any due diligence (or any other work) on whether its my changes or the repo that's at fault. But you can have a look in the mean-time: https://travis-ci.org/github/doublethefish/node-red-node-test-helper

p.s. the main repo seems to be failing which would be nice to see fixed https://travis-ci.org/github/node-red/node-red/jobs/718826913

knolleary commented 3 years ago

Thanks for the update.

We're well aware of the Travis status of the main repo and the activity going on to resolve that.