Document how to avoid assertions causing test timeout (issue #45)

node-red / node-red-node-test-helper

A test framework for Node-RED nodes

Apache License 2.0

57 stars 40 forks source link

Document how to avoid assertions causing test timeout (issue #45) #46

Closed mrubli closed 3 years ago

mrubli commented 3 years ago

This documents #45 in the README and updates the example accordingly.

jsf-clabot commented 3 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

mrubli commented 3 years ago

@knolleary Would you mind taking a look at this PR? After your recent fix for #48 (much appreciated, btw!) I wanted to improve the documentation on testing with the Catch node a bit and create a PR to resolve the long-standing #18 (basically adding to the existing doc with an example). Such documentation would have helped us greatly a couple of days ago. I was just hoping to resolve this PR first before I get started on a new one.

knolleary commented 3 years ago

Hi @mrubli

sorry for overlooking this one. All looks good to me.

mrubli commented 3 years ago

No worries. Thanks for merging!