search

node-red / node-red-node-test-helper

A test framework for Node-RED nodes
Apache License 2.0
57 stars 41 forks source link

Multiple 'catch' node in a flow causes "already registered" error #71

Open DraggonFantasy opened 10 months ago

DraggonFantasy commented 10 months ago

If the flow contains several 'catch' nodes (which are loaded by test-helper automatically as well as 'status' and 'complete' nodes which possibly will result in the same error), the tests crash with "catch already registered" error. The reason is probably with this code in index.js:

        testFlow.forEach(n => {
            if (this._nodeModules.hasOwnProperty(n.type)) {
                // Go find the 'real' core node module and load it...
                const result = this._nodeModules[n.type](red);
                if (result?.then) {
                    initPromises.push(result)
                }
                preloadedCoreModules.add(this._nodeModules[n.type]);
            }
        })

Which loads the core nodes without checking if they are already loaded in preloadedCoreModules.

As a workaround, I'm resetting helper._nodeModules before doing helper.load(), so it will not load any core nodes automatically, and then pass them to helper.load() manually

helper._nodeModules = {}
helper.load(coreNodes, flow, function () {
   ....
})