node-red / node-red-nodes

Extra nodes for Node-RED
Other
964 stars 592 forks source link

node-red-node-sqlite - DB filename doesn't support underscore #1038

Closed baxerus closed 6 months ago

baxerus commented 6 months ago

Which node are you reporting an issue on?

node-red-node-sqlite

What are the steps to reproduce?

  1. Configure a new database with an underscore in the name (I tried /data/sqlite/dwd_mosmix)
  2. Try a CREATE TABLE statement
  3. Nothing happens
  4. Change filename to something without underscore (I changed to /data/sqlite/dwd-mosmix)
  5. Retry step 2
  6. File gets created. Everything is working fine

What happens?

Nothing. No file appearing in the filesystem

What do you expect to happen?

Also file names with underscore do work. But even more important help the user understand and prevent the issue! By either a check on the input field that prevent not allowed chars (if there is a reason for this) or at least by throwing an error on the failed CREATE statement (other non-functional commands also show errors in the debug log)

Please tell us about your environment:

dceejay commented 6 months ago

This is working fine for me not using docker - so I guess it must be something to do with you docker file mount and/or permissions.

image
hardillb commented 6 months ago

Did you create the /data/sqlite directory first and is it fully rwx by the node-red user in the container (uid 1000 iirc)

baxerus commented 6 months ago

I tried again and now I also can not reproduce the issue (I could before opening this issue. Opening issues is to much effort to not retrying multiple times before).

I'm sorry and closing this issue.