node-red / node-red-nodes

Extra nodes for Node-RED
Other
988 stars 593 forks source link

[Suncalc] Fix English suncalc descriptions for dusk and nauticalDusk #1048

Closed Raphiiko closed 7 months ago

Raphiiko commented 7 months ago

Types of changes

Proposed changes

I believe the descriptions for the dusk and nauticalDusk might have been mixed up:

In the event descriptions for node-red's suncalc node, these are described as follows:

However in the reference for the underlying suncalc package, they are described differently:

The latter makes more sense to me, considering at night, astronomical twilight comes after nautical twilight. This PR corrects these descriptions.

Checklist

linux-foundation-easycla[bot] commented 7 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

dceejay commented 7 months ago

Thanks