Closed Raphiiko closed 7 months ago
I believe the descriptions for the dusk and nauticalDusk might have been mixed up:
dusk
nauticalDusk
In the event descriptions for node-red's suncalc node, these are described as follows:
suncalc
However in the reference for the underlying suncalc package, they are described differently:
The latter makes more sense to me, considering at night, astronomical twilight comes after nautical twilight. This PR corrects these descriptions.
grunt
:white_check_mark:login: Raphiiko / (d8c25af1a34f6b2bc102fe7b6f430ce26c701799)The committers listed above are authorized under a signed CLA.
Thanks
Types of changes
Proposed changes
I believe the descriptions for the
dusk
andnauticalDusk
might have been mixed up:In the event descriptions for node-red's
suncalc
node, these are described as follows:dusk
: "Dusk, Evening astronomical twilight starts"nauticalDusk
: "Evening nautical twilight starts"However in the reference for the underlying suncalc package, they are described differently:
dusk
: "dusk (evening nautical twilight starts)"nauticalDusk
: "nautical dusk (evening astronomical twilight starts)"The latter makes more sense to me, considering at night, astronomical twilight comes after nautical twilight. This PR corrects these descriptions.
Checklist
grunt
to verify the unit tests pass I believe this does not apply as this is a simple translation change