search

node-red / node-red-nodes

Extra nodes for Node-RED
Other
995 stars 595 forks source link

node-red-node-pi-mcp3008 add mcp3201 #845

Closed mhornsby closed 3 years ago

mhornsby commented 3 years ago

there's support for mcp3202 can mcp3201 be added

hardillb commented 3 years ago

As described in the template you deleted when opening the this issue, feature requests should be made on the Discourse forum or on Slack, not in issues.

But the node-red-node-pi-mcp3008 node depends on the mcp-spi-adc node to access the hardware, we can only support the devices it supports and it does not appear to support the mcp3201.

fivdi commented 3 years ago

MCP3201 support has just been added to mcp-spi-adc and is now available with mcp-spi-adc@3.2.0.

dceejay commented 3 years ago

Happy if someone wants to create raise and test a PR for this.

dceejay commented 3 years ago

@mhornsby - OK - I have pushed a potential fix/upgrade as version 0.4.0...

NOTE I DO NOT have a 3201 so please test and feedback here if it works... or not... Thanks

mhornsby commented 3 years ago

Can confirm it works. Only feedback is in the documentation says: Outputs a numeric msg.payload with a range of 0 to 1023, representing 0V to 3.3V. From mcp-spi-adc its 0 to 1023 for MCP30XX and 0 to 4095 for MCP32XX and MCP33XX. Many thanks !!

dceejay commented 3 years ago

Thanks - docs updated.