node-red / node-red-ui-nodes

Additional nodes for Node-RED Dashboard
Apache License 2.0
117 stars 81 forks source link

fix: able to set limits and setpoint to zero #92

Closed hoegge closed 1 year ago

hoegge commented 1 year ago

With the current implementation you cannot set any of the limits or the setpoint to zero, since 0 is falsy.

Proposed changes

You cannot set, e.g., low limit to 0 since 0 is falsy. Checking limits and setpoint for zero now and sets to 0 instead of default values in that case, which will confuse people.

Checklist

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

dceejay commented 1 year ago

Good catch . Thanks !