Deleting a grouped node should update the group - Githubissues

node-red / node-red

Low-code programming for event-driven applications

http://nodered.org

Apache License 2.0

18.96k stars 3.31k forks source link

Deleting a grouped node should update the group #4714

Closed GogoVega closed 1 month ago

GogoVega commented 1 month ago

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Fixes #4712

When the user deletes a grouped node from the edit box, the group must be updated in order to remove the node from the group.

PS: I don't know why indexOf doesn't return the correct value.

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run npm run test to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

GogoVega commented 1 month ago

Thanks, I will correct that. I created a clone because the "undo" was not doing what it should do. Let's see what happens with your idea.