Monaco-0-49-0 - Githubissues

node-red / node-red

Low-code programming for event-driven applications

http://nodered.org

Apache License 2.0

18.93k stars 3.31k forks source link

Monaco-0-49-0 #4725

Closed Steve-Mcl closed 4 weeks ago

Steve-Mcl commented 1 month ago

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Vendor update

Proposed changes

Updates monaco to latest V0.49.0

https://github.com/node-red/nr-monaco-build/releases/tag/0.49.0

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run npm run test to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

FabsMuller commented 1 month ago

Stephen, I sent you a pvt on NR forum.

knolleary commented 4 weeks ago

@Steve-Mcl does this correspond to a tagged release on https://github.com/node-red/nr-monaco-build ? I'd prefer that we are able to point to a tag on that repo when copying files over so we have a clear sense of their pedigree.

Steve-Mcl commented 4 weeks ago

@Steve-Mcl does this correspond to a tagged release on https://github.com/node-red/nr-monaco-build ? I'd prefer that we are able to point to a tag on that repo when copying files over so we have a clear sense of their pedigree.

No, but it does directly relate to the branch https://github.com/node-red/nr-monaco-build/tree/update-for-v4 which was updated first, to generate this PR

We could merge and tag that first if need be?

knolleary commented 4 weeks ago

I have merged and tagged the changes in the monaco repo. This PR syncs the changes from https://github.com/node-red/nr-monaco-build/releases/tag/0.49.0 into the NR repo