node-red / node-red

Low-code programming for event-driven applications

http://nodered.org

Apache License 2.0

18.93k stars 3.31k forks source link

chore: migrate api `node-sass` to `dart-sass` #4731

Closed Rotzbua closed 3 weeks ago

Rotzbua commented 4 weeks ago

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Migrate from legacy api (node-sass) to new api (dart-sass). https://sass-lang.com/documentation/js-api/#md:legacy-api

Effectively only replaces the function call.

Reference

4723

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run npm run test to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

bonanitech commented 4 weeks ago

3743 does that (and some other stuff). Should I close it in favor of this one?

knolleary commented 4 weeks ago

@bonanitech as you're probably the main user of the script, I'd value your input on which PR we should proceed with. We don't need both, but if you feel your PR addresses more items you'd like to see addressed, then we can go with that.

bonanitech commented 3 weeks ago

Thank you @knolleary

To be honest I don't use it anymore. I have one in the theme-collection repository.

But I think #3743 can benefit other people trying to create themes. With the changes made in that PR, the script will generate a file in the format Node-RED uses nowadays, containing only the CSS variables.

knolleary commented 3 weeks ago

Thanks @bonanitech - we'll close this one in favour of your other PR.