Update editor.scss - Githubissues

node-red / node-red

Low-code programming for event-driven applications

http://nodered.org

Apache License 2.0

18.93k stars 3.31k forks source link

Update editor.scss #4737

Open malee1975 opened 3 weeks ago

malee1975 commented 3 weeks ago

[ x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

It seems to be that when using Chrome and Edge on windows that the scrollbar is always visible until there is an action within the edit dialog. This issue seems to be specific to the configuration dialogs and is more pronounced if a dark theme is used.

Checklist

[x ] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run npm run test to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

linux-foundation-easycla[bot] commented 3 weeks ago

:x: - login: @malee1975 . The commit (7ae9d3bbb02a81cc90aad24905304f84b5fb44f8) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

knolleary commented 3 weeks ago

Thanks for this. I'm currently also looking at this one to see if there's a less fragile way of handling the resizing of the form. A lot of this was written before things like flex had wide support... but these days it's a given and might reduce the need for a lot of these 'magic' numbers that can vulnerable to change.

malee1975 commented 3 weeks ago

I am big fan of flex. I guess ultimately that it would need to be an editor wide implementation of flex.

knolleary commented 3 weeks ago

@malee1975 do you see this on all nodes or just some in particular? Which node is in the screenshot you shared in the original issue?

I don't see the scrollbar on Chrome using the default NR theme - I'm wary of making this type of pixel-tweaking change if we can't reproduce generally.

malee1975 commented 3 weeks ago

All nodes with a configuration dialog, for example this is on Edge: Screenshot 2024-05-30 135054 And this a different node on Chrome (Version 125.0.6422.113) Screenshot 2024-05-30 135359 As soon as I input anything into the inputs there is a shift to the right as the scrollbar is removed. I am on Windows OS version 11.

knolleary commented 3 weeks ago

As mentioned, I don't see this on Chrome/MacOS.

@Steve-Mcl as a resident Windows user, could you say if you see this behaviour at all? I'm wary of making these mini-pixel tweaks if they aren't widely reproducable.

GogoVega commented 3 weeks ago

I don't have it on all my config nodes - I deduce that it only affects the dialog box if it has the default size.