search

node-red / node-red

Low-code programming for event-driven applications
http://nodered.org
Apache License 2.0
18.93k stars 3.31k forks source link

Grunt: build script does not fail if source files are missing #4738

Closed Rotzbua closed 3 weeks ago

Rotzbua commented 3 weeks ago

Current Behavior

Builds without any warning or error.

Expected Behavior

Build should warn or fail.

Steps To Reproduce

Delete random required file.

Example flow

No response

Environment

knolleary commented 3 weeks ago

@Rotzbua I'd love to get some insight into how you are identifying these issues? We've never had a problem with the grunt file and your description doesn't really give any insight into the full scenario.

We are also trying to finalise the 4.0 release - whilst we certainly appreciate all of the prs you are raising, it would be good to get a better idea of what you are doing more generally as the areas you are raising against are jumping all over the project.

Rotzbua commented 3 weeks ago

I'm currently tinkering with the editor client and the dependencies. (A part of this tinkering was #4701) I noticed that jqeuery is a local copy in the repo but for jquery-i18next the npm repo is used as source. So I tried to replace the local copy with npm dependency but the build did not failed while testing. In my opinion, it is also an counter intuitive behavior of grunt not to rise a warning if a file is explicitly specified in a build script and not available.

Rotzbua commented 3 weeks ago

fixed by #4739