search

node-red / node-red

Low-code programming for event-driven applications
http://nodered.org
Apache License 2.0
18.93k stars 3.31k forks source link

editor-client: mixed dependencies #4741

Open Rotzbua opened 3 weeks ago

Rotzbua commented 3 weeks ago

Current Behavior

As mentioned in https://github.com/node-red/node-red/issues/4738#issuecomment-2139489439 editor-client uses mixed dependencies: local copies and npm.

Expected Behavior

It would be beneficial to have most dependencies managed by npm and just custom build dependencies as local copy. Advantage: with npm outdated it is easier to keep overview over outdated dependencies. Disadvantage: currently build does not warn if required files due path or naming change are not available fixed by #4739

Steps To Reproduce

npm dependency:

local copy which can be moved to npm:

notes:

@knolleary give me a ping if I should create a pr.

Environment

knolleary commented 3 weeks ago

Please hold off on this. It is not something we will do for 4.0 and I don't want to do lots of core dependency updates right before the release.

Rotzbua commented 3 weeks ago

My current draft is the exact same version as the local copy. No version bump of the dependencies.

knolleary commented 3 weeks ago

You are welcome to raise a PR - just know I'm being very selective as to what gets merged in the next few days to keep 4,0 on track.