Remove SASS variables marked as deprecated - Githubissues

node-red / node-red

Low-code programming for event-driven applications

http://nodered.org

Apache License 2.0

18.93k stars 3.31k forks source link

Remove SASS variables marked as deprecated #4767

Open bonanitech opened 1 week ago

bonanitech commented 1 week ago

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

As discussed in today's live stream, I'm proposing the removal of the SASS variables marked as deprecated since May 27, 2021, in #2994 (merged before Node-RED 2.0.0-beta.1).

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run npm run test to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

bonanitech commented 1 week ago

Also, there are 12 CSS selectors marked as deprecated since May 17, 2019, in #2158 (merged before 1.0.0-beta.1).

Full list:

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/editor.scss#L272

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/editor.scss#L273

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/editor.scss#L291

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/editor.scss#L292

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/flow.scss#L31

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L83

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L93-L96

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L97-L100

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L103

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L115

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L116

https://github.com/node-red/node-red/blob/dev/packages/node_modules/%40node-red/editor-client/src/sass/sidebar.scss#L125

Should I add those to this PR?