node-red / nr-monaco-build

Build tools for bundling the Monaco editor in Node-RED
Apache License 2.0
6 stars 6 forks source link

Add vue language server support #9

Open Steve-Mcl opened 9 months ago

Steve-Mcl commented 9 months ago

Add support for vue syntax checking - goes hand in hand with Dashboard 2.0 which is vue based.

See here for details: https://discourse.nodered.org/t/weather-card-strugguling-with-methods/85434/6?u=steve-mcl

dceejay commented 9 months ago

Does this volar library mentioned (13MB) get installed on every load ? or only if you edit dashboard ?

Steve-Mcl commented 9 months ago

It'll hopefully be ~4mb once compiled/minified (the other existing web workers for Monaco are) but if done right, should only requested when the editor calls for that language. It'll be held in memory while NR editor is open & should be cached for future reloads.

dceejay commented 9 months ago

can it be added as (a plugin?) part of the dashboard2 install ?

Steve-Mcl commented 9 months ago

Hmmmm. Maaaaybe. I mean anything is possible. Would need to be coordinated between the 2.

Will give it some thought.

dceejay commented 9 months ago

IE - could either onpaletteadd cause it to be loaded - or maybe an npm post install script to move worker into correct place to be picked up automatically - then again if it really is only 4MB - what's another bit of bloat between friends... (Does seem like a useful thing to help Dashboard2)

joepavitt commented 7 months ago

(Does seem like a useful thing to help Dashboard2)

Can vouch for the value on Dashboard 2.0 here - we're getting people ask for it daily.