search

node-red / nrlint

Node-RED Flow Linter
Apache License 2.0
36 stars 15 forks source link

fix no-loop rule to detect real loop #10

Closed HiroyasuNishiyama closed 3 years ago

HiroyasuNishiyama commented 3 years ago

Proposed changes

Current no-loop rule detects branch and merge style flow as a loop. This PR tries to fix this problem.

Example Flow:

[{"id":"3f3805b7245f528f","type":"inject","z":"3c0fb64276fb33ea","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":180,"y":180,"wires":[["6a4a3e6ee7c23349"]]},{"id":"2be3b9c3ad9715cb","type":"debug","z":"3c0fb64276fb33ea","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":550,"y":180,"wires":[]},{"id":"5c3b192920339b4d","type":"inject","z":"3c0fb64276fb33ea","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":180,"y":280,"wires":[["239a0b42220e3b47"]]},{"id":"37c7b6175e3c6020","type":"debug","z":"3c0fb64276fb33ea","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":550,"y":280,"wires":[]},{"id":"6a4a3e6ee7c23349","type":"switch","z":"3c0fb64276fb33ea","name":"","property":"payload","propertyType":"msg","rules":[{"t":"eq","v":"1","vt":"str"},{"t":"eq","v":"2","vt":"str"}],"checkall":"true","repair":false,"outputs":2,"x":350,"y":180,"wires":[["2be3b9c3ad9715cb"],["2be3b9c3ad9715cb"]]},{"id":"239a0b42220e3b47","type":"switch","z":"3c0fb64276fb33ea","name":"","property":"payload","propertyType":"msg","rules":[{"t":"eq","v":"1","vt":"str"},{"t":"eq","v":"2","vt":"str"}],"checkall":"true","repair":false,"outputs":2,"x":350,"y":280,"wires":[["37c7b6175e3c6020"],["334003fb2e16c024"]]},{"id":"334003fb2e16c024","type":"change","z":"3c0fb64276fb33ea","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":360,"y":340,"wires":[["239a0b42220e3b47"]]}]

Checklist