search

node-red / nrlint

Node-RED Flow Linter
Apache License 2.0
36 stars 15 forks source link

eslint4b requires eslint to be installed as well #9

Closed knolleary closed 1 year ago

knolleary commented 3 years ago

I have noticed that to webpack eslint4b, eslint needs to be installed as well.

I tried adding it as a devDependency and the webpack worked. But then the non-webpack version failed to run as it couldn't find a bunch of eslint modules.

The strange thing is eslint4b has eslint as a dependency itself, so I don't understand why it is failing.

I don't want to have both eslint4b and eslint listed as dependencies as that is double the install size.

I have raised an issue on eslint4b to seek any guidance they can share - https://github.com/mysticatea/eslint4b/issues/11

knolleary commented 3 years ago

I have added @eslint/eslintrc as a dependency which seems to be enough, rather than the full eslint module.

Ideally the eslint4b issue will be fixed so we can remove that as well, but there has been no response from its maintainer.

knolleary commented 1 year ago

WE've now moved away from eslint4b so this issue can be closed - see #39