search

node-strava / node-strava-v3

API wrapper for Strava's v3 API, in Node
MIT License
354 stars 109 forks source link

stream test fails (due to bug in test) #117

Open markstos opened 3 years ago

markstos commented 3 years ago

This test is failing:

streams_test
    #activity()
           1) should return raw data associated to activity

URL called is like: url: 'routes/2849314360760640500/streams/?resolution=low',

Error is: StatusCodeError: 404 - {"message":"Resource Not Found","errors":[]}

From reading the API docs, it seems like routes like this should exist, so maybe it's a bug in our test.

Yep. The test contains a hardcoded activity ID, which could have only possibly worked for the original developer. The fix would be to generate the test activity-with-segment, then run the test, then remove it.
edilson commented 2 years ago

@markstos i believe we could improve the tests by adding a pipeline to the project, then it would be possible to add the credentials by env var and we could validate if the tests are passing or not.

markstos commented 2 years ago

Good idea. I'm making you an owner of the new node-strava organization so you can implement it.

BTW, Strava seems not to mind if extra test accounts are created for the purpose of creating additional API keys. They are aware that my company creates them on behalf of customers so that each customer's domain has a separate API key.

Creating a test account that's used exclusively test a Node.js Strava API client seems like a fair use.