search

node-strava / node-strava-v3

API wrapper for Strava's v3 API, in Node
MIT License
356 stars 109 forks source link

not loading env variables with custom names #126

Closed ragnarok22 closed 2 years ago

ragnarok22 commented 2 years ago

Env variables like STRAVA_CLIENT_SECRET and STRAVA_ACCESS_TOKEN work fine but changing to NEXT_PUBLIC_STRAVA_CLIENT_SECRET doesn't work

ragnarok22 commented 2 years ago

Reviewing the main branch seems fixed but no in version v2.1.0. Please release a new minor version

markstos commented 2 years ago

Custom environment variable names are not supported. Fork the project if you want that feature. Or do:

process.env.STRAVA_CLIENT_SECRET = process.env.NEXT_PUBLIC_STRAVA_CLIENT_SECRET before the environment variable is used.

I'm also not sure about the "main branch seems fixed" comment. Looking at it, I don't see new commits beyond what was released in 2.10.0.