search

node-strava / node-strava-v3

API wrapper for Strava's v3 API, in Node
MIT License
356 stars 109 forks source link

Allow property SportType in strava.activities.update #130

Closed pro-sumer closed 1 year ago

pro-sumer commented 2 years ago

Strava introduced a new property SportType:

SportType: An enumeration of the sport types an activity may have. Distinct from ActivityType in that it has new types (e.g. MountainBikeRide)

Can you please add this to the allowed properties for strava.activities.update?

I think you only need to add it to the _updateAllowedProps array in activities.js to support this?

(use case: bulk changing my "rides" to MTB rides)

markstos commented 2 years ago

PR welcome. In the PR submission, please provide notes about how the change was tested.

markstos commented 2 years ago

This is a community-maintained module now. The original author is no longer active. I'm another user like you who happens to have commit access. I don't need this feature now but am willing to review and release it.

pro-sumer commented 2 years ago

PR #132 submitted to solve this issue.