node-strava / node-strava-v3

API wrapper for Strava's v3 API, in Node
MIT License
356 stars 109 forks source link

Update util.js #71

Closed Noah-Silvera closed 5 years ago

Noah-Silvera commented 6 years ago

Fix a property with a value of 0 ( such as { after: 0 }, when requesting for all strava activities since the dawn of time ) from not being included in a query string.

I found this error when trying to execute this statement.

strava.athlete.listActivities({ after: 0})

The "after" query string was not included because it's value was 0.

markstos commented 5 years ago

Adding an automated test will confirm which syntax is correct.

markstos commented 5 years ago

This change will be in the next version, but there are so many changes in the new version that the change has been manually applied. Closing this.