search

node-ts / bus

A typescript based enterprise service bus framework based on enterprise integration patterns
https://bus.node-ts.com/
MIT License
271 stars 25 forks source link

FIX #200: Support Mongodb Persistence for WF #201

Closed manarhusrieh closed 1 year ago

manarhusrieh commented 1 year ago

I was using the library workflow part and came across the case where I needed to use Mongodb as a persistence for states.

High level changes:

@adenhertog I have copied this implementation from bus-postgres package that exists in the project.

adenhertog commented 1 year ago

hey @manarhusrieh thanks for the PR - looking forward to getting this merged.

I've checked it out locally to have a bit of a play with it and it looks really good. Just left a few comments for your consideration, so let me know when you'd like me to have another look 🙂

manarhusrieh commented 1 year ago

@adenhertog thanks for looking at the PR and I will fix these comments. Regarding commits, do you want me to amend the commit and push again? Or shall I just push a new commit and you will squash them during merge?

adenhertog commented 1 year ago

Hey @manarhusrieh, whatever you prefer. I'll end up squash committing, so feel free to push as many commits to this PR as you need

manarhusrieh commented 1 year ago

Hey @adenhertog, I have pushed a new commit to handle the changes you have requested. Please review again.

adenhertog commented 1 year ago

looks great! thanks @manarhusrieh I'll roll a new version with this in it