nodeSolidServer / node-solid-server

Solid server on top of the file-system in NodeJS
https://solidproject.org/for-developers/pod-server
Other
1.78k stars 303 forks source link

Response header for requests to ACL resources serve weird header Link rel=acl #1456

Open megoth opened 4 years ago

megoth commented 4 years ago

Currently NSS will serve a response with Link rel=acl that points to another ACL resource, e.g. https://megoth.solid.community/.acl will have a Link rel=acl that points to https://megoth.solid.community/.acl.acl.

I don't think the .acl.acl file pattern is allowed according to the spec, and I would suggest another solution. Perhaps change the Link to rel=acl self and point to the ACL resource itself? Or drop the Link header altogether?

timbl commented 4 years ago

Strongly suggest removing the acl header completely

csarven commented 4 years ago

https://github.com/solid/web-access-control-spec#referring-to-the-acl-resource-itself doesn't actually restrict the possibility of implementations to advertise ACLs of ACLs. The current draft of the Solid spec doesn't either so there is indeed the possibility of implementations going down that road. I've raised https://github.com/solid/specification/issues/184 to address this with proposed requirements for auxiliary resources. One of which will prevent the case altogether as Tim suggest above.

See also https://gitter.im/solid/specification?at=5ee73bc0a85de3039414bbc2 .