search

nodeSolidServer / node-solid-server

Solid server on top of the file-system in NodeJS
https://solidproject.org/for-developers/pod-server
Other
1.78k stars 303 forks source link

Malformed uri:s on Windows #1534

Open highlevellogic opened 3 years ago

highlevellogic commented 3 years ago

Windows 10, NSS v5.5.6

Added a Trusted App via the data browser and that resulted in a modified card$.ttl file with malformed URI:s such as:

pim:preferencesFile
    <https://rogerfgay.solid.hll.nu:7443%2Fprofile%2Fcard//settings/prefs.ttl>;

Since I'm stuck on Windows, I don't mind trying to fix this, but I'm still a bit of a newbie and would appreciate being pointed to the parts of NSS that are likely to be where the problem is.

bourgeoa commented 3 years ago

Now you have 2 branch apparently you made a commit from windows-fix1 to windows-fix I thought you could commit without having windows-fix-1

I am not more an expert than you. I discovered all that 2 days ago

Anyhow you made it.

The error is in resource-mapper.js line 9

/home/runner/work/node-solid-server/node-solid-server/lib/resource-mapper.js:9:7: 'pathUtil' is assigned a value but never used.

highlevellogic commented 3 years ago

OK. Now I just need to know how to run the tests. Still getting no package.json errors.

bourgeoa commented 3 years ago

You must first pass standard. From the windows-fix branch or windows-fix-1 (I dont know ?) Delete or comment the line in resource-mapper then commit and the tests will re-run. May be not If you are not in the good branch

If it does not work : I would delete one of the 2 branches and redo from beginning may be doing first the correction in resource-mapper not to have the previous lint error

bourgeoa commented 3 years ago

to delete a branch you must go to the menu 117 branches I realize that your fork was not the creator of windows-fix. It is a branch you created in solid/node-solid-server with your PR That is why all that is not working properly.

If I am right you must redo from the beginning with a different new branch that you create from your highlevellogic fork

highlevellogic commented 3 years ago

I was worried about about where the windows-fix branch actually was. When I choose a branch, there are many others listed that I did not create.

highlevellogic commented 3 years ago

windows-test

highlevellogic commented 3 years ago

This almost looks right, I think. Do I need to delete the existing node.js.yml and rename this new one ?

bourgeoa commented 3 years ago

This almost looks right, I think.

in https://github.com/highlevellogic/node-solid-server/blob/windows-test/.github/workflows/node.js.yml code you need to change the branch to windows-test in 

on:
  push:
    branches: [ windows-fix ]
  pull_request:
    branches: [ windows-fix ]

Do I need to delete the existing node.js.yml and rename this new one ?

you can delete windows-fix1 branch Then you only make your tests in windows-test branch

bourgeoa commented 3 years ago

Why do you have 2 files node.js.yml and windows.js.yml only one is enough Containing the branch on which you are making the tests to make your test in windows-test you should commit to windows-test

highlevellogic commented 3 years ago

The first one was created during my earlier attempt. It's in the master. Created yesterday. I tried to delete it but delete is grayed out on the menu.

highlevellogic commented 3 years ago

OK, I had to view file first and reset the branch. I have deleted node.js.yml from the master but github still saying that a file by that name already exists when I try to change name from windows.js.yml

I have also edited windows.js.yml with the changes you described above.

highlevellogic commented 3 years ago

And there is another one - sorry for missing that. Edited node.js.yml on windows-test. Deleting windows.js.yml

bourgeoa commented 3 years ago

So when I got to the actions menu I see your last test that run in windows-test. That is perfect Fail on standard in resource-mapper.js line 9 That is OK

bourgeoa commented 3 years ago

go to actions menu and you will see your tests running on each change

highlevellogic commented 3 years ago

Automatically? When I submit something? I usually just upload files to make changes.

highlevellogic commented 3 years ago

Looking around clicking ... seeing that tests have been run and failed.

bourgeoa commented 3 years ago

Yes that is OK

standard: Use JavaScript Standard Style (https://standardjs.com) /home/runner/work/node-solid-server/node-solid-server/lib/resource-mapper.js:9:7: 'pathUtil' is assigned a value but never used. npm ERR! code ELIFECYCLE

and now make the correction delete or comment line 9 in resource-mapper.js

highlevellogic commented 3 years ago

OK cool. I guess I have a more professional project environment now. Thanks. I'll play around a bit more this afternoon.

bourgeoa commented 3 years ago

Wonderful I saw you passed standard and now have tests running and failing in windows.