search

nodeSolidServer / node-solid-server

Solid server on top of the file-system in NodeJS
https://solidproject.org/for-developers/pod-server
Other
1.78k stars 299 forks source link

n3-patch #1747

Closed bourgeoa closed 6 months ago

bourgeoa commented 9 months ago

rdflib@2.3.33 implement n3-patch, migrate the NSS to use directly n3-patch. Actually NSS uses a n3-patch parser to SPARQL https://github.com/nodeSolidServer/node-solid-server/blob/main/lib/handlers/patch/n3-patch-parser.js

zg009 commented 6 months ago

Alain are you referring to using this function for n3-patches? https://github.com/linkeddata/rdflib.js/blob/7a40abfffcdfe7c31f8ada7b85677787641348c8/src/update-manager.ts#L860

bourgeoa commented 6 months ago

Well Rdflib has a way to construct a n3Patch https://github.com/linkeddata/rdflib.js/blob/7a40abfffcdfe7c31f8ada7b85677787641348c8/src/update-manager.ts#L815

NSS deliver n3Patch

And I don't know if he can consume them directly. Not sure

zg009 commented 6 months ago

I think if the n3 patch parser is not being used to process N3 PATCH requests, another parser can be made that makes use of rdflib, and then processes N3 PATCH requests

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Alain Bourgeois @.> Sent: Tuesday, March 19, 2024 2:02:08 AM To: nodeSolidServer/node-solid-server @.> Cc: Zachary Grider @.>; Comment @.> Subject: Re: [nodeSolidServer/node-solid-server] n3-patch (Issue #1747)

Well Rdflib has a way to construct a n3Patch https://github.com/linkeddata/rdflib.js/blob/7a40abfffcdfe7c31f8ada7b85677787641348c8/src/update-manager.ts#L815

NSS deliver n3Patch

And I don't know if he can consume them directly. Not sure

— Reply to this email directly, view it on GitHubhttps://github.com/nodeSolidServer/node-solid-server/issues/1747#issuecomment-2006009501, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYZIGJJJ3Q7SSOULHVPNPX3YY7PHBAVCNFSM6AAAAABA3M6RGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWGAYDSNJQGE. You are receiving this because you commented.Message ID: @.***>

bourgeoa commented 6 months ago

Yes but we have already one in NSS Then the issue can be closed

zg009 commented 6 months ago

I wrote some tests in n3-patch branch, if you could check. And explain what needs to be tested for accuracy

I think there needs to be a request handler or middleware, to check if a PATCH request targets RDF content-type and body can be handled by n3 patch parser parsePatchDocument function. Then an integration test and it should work

Edit: I also saw this comment here : https://github.com/nodeSolidServer/node-solid-server/issues/1703#issuecomment-1242792498

Does this mean n3-patch is already working as intended, or is this an update to an old spec?

bourgeoa commented 6 months ago

Does this mean n3-patch is already working as intended, or is this an update to an old spec?

n3Patch is working as intended see patch

zg009 commented 6 months ago

OK then this issue can be closed?

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Alain Bourgeois @.> Sent: Thursday, March 21, 2024 2:24:21 AM To: nodeSolidServer/node-solid-server @.> Cc: Zachary Grider @.>; Comment @.> Subject: Re: [nodeSolidServer/node-solid-server] n3-patch (Issue #1747)

Does this mean n3-patch is already working as intended, or is this an update to an old spec?

n3Patch is working as intended see patch

— Reply to this email directly, view it on GitHubhttps://github.com/nodeSolidServer/node-solid-server/issues/1747#issuecomment-2011368678, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYZIGJJWUY7YKLHKNBDGJNLYZKDKLAVCNFSM6AAAAABA3M6RGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGM3DQNRXHA. You are receiving this because you commented.Message ID: @.***>