Open michielbdejong opened 5 months ago
@bourgeoa it seems the behaviour of NSS has diverged from what the WAC tests prescribe. I know there was a discussion about this in the matrix chat but didn't follow the whole conversation. What is the current status? Is there now still a difference in how we interpret the WAC spec, that causes this diversion? If so I'll tag the 5 failing tests as disputed.
@michielbdejong
FIXME, intermittent in the WAC tests: 1 failed, 2 skipped, 88 passed, 91 total
This is a real pain. I always :
The main environment difference is the node version :
21 on the CI
I tried node 21 locally and tests passes. I just added IPv6 localhosts in /etc/hosts :
::1 localhost
::1 alice.localhost
::1 bob.localhost
Could it be due to :
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks.
The message disappear if I add --detectOpenHandles
to jest
@michielbdejong
it seems the behaviour of NSS has diverged from what the WAC tests prescribe
is Append
allowed on PUT and PATCH ?
the following discussion https://github.com/solid/web-access-control-spec/issues/122 concluded that there was no need to change the spec
:
--> Append
is allowed for PUT for create (the resource do not exist)
This has since been implemented in CSS v7.0.3, was not tested and is still not tested in the specifications tests see https://github.com/solid-contrib/specification-tests/issues/111
--> Append
is also allowed on C/ for PATCH to create
Following your request some rewrite to the spec has been made as a clarification
https://github.com/solid/web-access-control-spec/pull/128/files
NSS is now passing all specification-tests. you can run these on https://solidcommunity.net:8443 which is today aligned with NSS main
bourgeoa@DESKTOP-PIRJOCS:/mnt/d/github/specification-tests$ cat nss.env
quarkus.log.category."org.solid.testharness.http.Client".level=DEBUG
USERS_ALICE_WEBID=https://alice.solidcommunity.net:8443/profile/card#me
USERS_BOB_WEBID=https://bob.solidcommunity.net:8443/profile/card#me
LOGIN_ENDPOINT=https://solidcommunity.net:8443/login/password
USERS_ALICE_USERNAME=alice
USERS_ALICE_PASSWORD=123
USERS_ALICE_IDP=https://solidcommunity.net:8443/
USERS_BOB_USERNAME=bob
USERS_BOB_PASSWORD=123
USERS_BOB_IDP=https://solidcommunity.net:8443/
bourgeoa@DESKTOP-PIRJOCS:/mnt/d/github/specification-tests$ ./run.sh nss.env
I have been unable to run the specification tests on https://localhost:8443
For information but may not impact the actual test-suite.
NSS has been updated to follow the spec on DELETE :
CI is now back running in NSS
I patched in the solid-crud-tests to remove await in rdflib.parse parameters from
rdflib.parse(await result.text(), store2, resourceUrl, "text/turtle");
to
const resultText = await result.text()
rdflib.parse(resultText, store2, resourceUrl, "text/turtle");
CI is now back running in NSS
I got this passing:
(FIXME, intermittent in the WAC tests: 1 failed, 2 skipped, 88 passed, 91 total)
To do: