search

nodeSolidServer / node-solid-server

Solid server on top of the file-system in NodeJS
https://solidproject.org/for-developers/pod-server
Other
1.77k stars 297 forks source link

fix issue 1770: #1773

Closed zg009 closed 3 months ago

zg009 commented 3 months ago

changed error handling of attempting to send password reset on nonexistent user: view issue 1770

@bourgeoa , I wasn't sure what you meant by changing that one line, as I could not find a fix without changing how the accountManager worked downstream, so I simply added an error code check to if request.validate() fails it still passes through the catch.

If you have a better idea let me know and I will change + test

bourgeoa commented 3 months ago

@zg009 I'm sorry I have not been very clear to the changes I was thinking of.

Do you work locally ? if yes you should npm run test before push. If you need any help please ask.

Usually after a PR it is good practice to come back and look a the tests. Thereafter clear any issue due to your changes.

zg009 commented 3 months ago

I saw the test fail, I thought I had passed the linting check but had forgotten to save, so I committed without fixing the formatting issues.

Edit: And it is okay, I didn't know you could return a non-Promise value from a Promise after all. Should I also change the comment above resetLinkMessage() since it no longer throws an Error?